Skip to content

Add per-segment review reasons for plugins - #1600

Merged
raivisdejus merged 4 commits into
chidiwilliams:mainfrom
Dicur3x:codex/segment-review-reasons
Sep 11, 2026
Merged

raivisdejus merged 4 commits into
chidiwilliams:mainfrom
Dicur3x:codex/segment-review-reasons

Conversation

@Dicur3x

@Dicur3x Dicur3x commented Aug 30, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add a review_reasons list to transcription segments for post-processing plugins
  • persist the reasons as JSON across completed, skipped, replaced, and legacy cached transcriptions
  • migrate existing databases with an empty-list default, preserving existing segment text
  • highlight affected rows in the transcription viewer and show every reason in a tooltip

Motivation

after_transcription plugins can currently rewrite segments, but they have no non-destructive way to ask the user to review a specific row. This adds that viewer integration without implementing or coupling Buzz to a particular detector.

This supports #1570. A repetition/hallucination detector can be proposed separately after the segment contract is agreed on.

Tests

  • database migration from the previous segment schema
  • review-reason persistence through all three segment save paths
  • viewer background and tooltip roles
  • Python compile check and Ruff check on the changed files

@Dicur3x
Dicur3x marked this pull request as ready for review August 30, 2026 11:24
@raivisdejus

Copy link
Copy Markdown
Collaborator

@Dicur3x Thanks for your contribution!

Let's make the new data field more universal, say metadata not review_reasons and let's make it store key-value pairs, say a list of dicts. This will let us store more data for different future plugins.

I would also add such metadata field on the transcription DB entries for the same future flexibility

Tooltip could show Key: vaue list for now.

@raivisdejus
raivisdejus force-pushed the codex/segment-review-reasons branch from 2eefd2b to 7cb2ae9 Compare September 11, 2026 20:16
@raivisdejus
raivisdejus enabled auto-merge (squash) September 11, 2026 20:32
@codecov

codecov Bot commented Sep 11, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 86.84211% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 83.62%. Comparing base (f70a02f) to head (7cb2ae9).

Files with missing lines Patch % Lines
...ion_viewer/transcription_segments_editor_widget.py 82.14% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1600      +/-   ##
==========================================
+ Coverage   83.58%   83.62%   +0.03%     
==========================================
  Files         113      113              
  Lines       12990    13023      +33     
==========================================
+ Hits        10858    10890      +32     
- Misses       2132     2133       +1     
Flag Coverage Δ
Linux 82.80% <86.84%> (+0.02%) ⬆️
macOS 83.14% <86.84%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@raivisdejus
raivisdejus merged commit 2d7d9dd into chidiwilliams:main Sep 11, 2026
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants